Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup window on Mac in iTerm2 not displaying correctly #4

Closed
bdillahu opened this issue Feb 12, 2021 · 5 comments
Closed

Popup window on Mac in iTerm2 not displaying correctly #4

bdillahu opened this issue Feb 12, 2021 · 5 comments

Comments

@bdillahu
Copy link

One last issue report, sorry.

On a Mac, in iTerm2, with or without tux, the height of the windoww background (the light grey) is full height, and the border doesn't draw except on the left and top.

Not sure...

Screen Shot 2021-02-11 at 19 10 11

@gennaro-tedesco
Copy link
Owner

gennaro-tedesco commented Feb 12, 2021

The size of the floating window is specified by these options: have you changed them to some other values?

If not, please try to explicitly set them by indicating (in your init.vim or anywhere else in your config):

lua require('nvim-peekup.config').geometry["height"] = 0.8 
lua require('nvim-peekup.config').geometry["width"] = 0.8 

taking into account that they must be 0 < x < 1 since they refer to the ratio with respect to the entire window size.

Moreover, do you by any chance have any other terminal multiplexers active/open while using it that may affect the window panel sizes?

@bdillahu
Copy link
Author

I tried with the geometry set... no difference.

Can't think of (or find reading back through my config) anything I have running except tmux - and I tried inside and outside it.

I know I've seen this one time before playing with something, but for the life of me can't remember what now. I'll plug at it... don't spend time if you aren't seeing it, probably something in my setup.

@gennaro-tedesco
Copy link
Owner

gennaro-tedesco commented Feb 12, 2021

Could you try with a fresh instance of iTerm2, namely without any configuration (both when it comes to tmux and to the shell you are running)? I have developed and tested it on iTerm2 exactly (both on Mac and on Linux) and did not see such problem (so I guess it must be some sort of config whose interaction with the neovim window messes up the sizes).

If you still see the problem this is where the window sizes are defined. You could try to peek what values they are returning in your case (basically just insert a line with print(total_height, win_height) to check the corresponding values). As you can see there are explicit checks that avoid the floating window size to exceed the vim window.

@bdillahu
Copy link
Author

OK, I've found it I believe...

Wasn't iTerm... it was a vim plugin I use:

roman/golden-ratio

It sets pane sizes to be the "golden ratio" instead of just "half" or whatever.

I don't use panes very often in vim anyhow, so for now just disabled it - once it's gone, peekup is happy.

@gennaro-tedesco
Copy link
Owner

All is well that ends well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants