Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deckgl ver9 #117

Closed
deanm0000 opened this issue Mar 27, 2024 · 9 comments
Closed

Deckgl ver9 #117

deanm0000 opened this issue Mar 27, 2024 · 9 comments

Comments

@deanm0000
Copy link

I got an error about multiple versions of deck.gl. They're up to v9.

@kylebarron
Copy link
Member

Yes it's in progress. #112

@atmorling
Copy link
Contributor

I'd be keen to help with this if I can.

I've got a build based on your PR with everything on the latest 9.0.12 of deck.gl, and the examples for which data is available (point, poly and multi-poly) all seem to work fine. Happy to go off and test the other examples with applicable data that I can find/generate.

Is this just a matter of bump and test the examples or is there a little more to it?

@kylebarron
Copy link
Member

kylebarron commented May 3, 2024

Indeed, it really is just a matter of bumping the versions and testing the examples. I haven't looked at the full change list for deck.gl v9 and if there's any change to the binary interface that I should watch out for. But from my exploration in #112 I didn't seem to hit any blockers.

A PR would be great!

One other thing to note, I've had some initial discussion with the deck.gl team about starting the process of upstreaming this into deck.gl. They suggested first moving work to the visgl/deck.gl-community repo to incubate the project and later possibly upstream it into deck.gl proper. See visgl/deck.gl-community#67

I haven't had the time yet to look at the fork made there. I've been more focused on the Python side in Lonboard. The build system in deck.gl-community is quite different I think. It's probably ok to make PRs here with the expectation of later making PRs to update "upstream" from here. But open to thoughts/feedback

@atmorling
Copy link
Contributor

Cool! It seems like they've already bumped everything upstream so I guess that's covered.

I expect there isn't a need to bring additions they've made back into this repo, but let me know what you think.

@kylebarron
Copy link
Member

I don't know whether it's worth synchronizing the repos.

I think primarily it'll just be annoying to follow the deck.gl-community release schedule, because so far I've published a new version here whenever I wanted to use something in lonboard. But maybe we can publish new upstream alpha versions as well regularly.

@atmorling
Copy link
Contributor

In that case I'll submit a PR to this repo for the build I linked above with deck.gl bumped.

@kylebarron
Copy link
Member

Closed by #112

@Youssef-Harby
Copy link

Can you please release the new deckgl 9 to npm ? @kylebarron

@kylebarron
Copy link
Member

I published @geoarrow/[email protected] with the latest main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants