-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a layers panel #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks!
My comments are only nitpicky comments about the naming of layersTree
. It seems a bit heterogeneous in the code-base between layersTree
, layerTree
and treeLayers
so I'm suggesting going for layersTree
everywhere.
Your are right for some of them, but maybe not for all. The second come from the fact that I used a Maybe we should declare the tree as a "items": {
"oneOf": [
{"type": "string"},
{
"type": "object",
"$ref": "#/definitions/jGISLayerGroup"
}
]
} It would clarify the naming and the tree object, avoiding useless properties, since the tree should only be a list of layers and groups (if I'm not mistaken). |
Oh ok I see.
That sounds good to me. Then you only operate on this |
Exact, let's update it then. |
@martinRenou I updated the schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks!
* Add the layer tree in shared document * Very first version of layers panel * Add a layers list under group, and a current selected layer in IJupyterGISModel * Add forgotten file from previous commit * Fix doc, lint and add docstring * Add an icon for raster layers * Style on icon * Add a visibility icon and fix the visibility layer with mapLibre * Add ui tests * Updates the example jGIS file after rebase * Chnage the LayersTree to a list of Layer or LayersGroup, and harmonize names
Add a layer panel to the left.
Remaining for this PR:
Probably in a follow up PR: