Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the collaborative document #18

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix the collaborative document #18

merged 1 commit into from
Jun 26, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jun 26, 2024

This PR fix the name of the file type in shared model factory.

@brichet brichet requested a review from martinRenou June 26, 2024 13:12
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupytergis/fix_collaborative-document

@brichet brichet added the bug Something isn't working label Jun 26, 2024
@brichet
Copy link
Collaborator Author

brichet commented Jun 26, 2024

It probably explains this comment
https://github.com/QuantStack/jupytergis/blob/39c4b38141e2df8e002da2b491fee45de0e59979/packages/base/src/mainview/mainview.tsx#L125-L127

@brichet brichet merged commit 21466a9 into geojupyter:main Jun 26, 2024
10 of 11 checks passed
@brichet brichet deleted the fix_collaborative-document branch June 26, 2024 13:41
gjmooney pushed a commit to martinRenou/jupytergis that referenced this pull request Jun 27, 2024
@brichet @gjmooney
Fix the name of the file type in shared model factory (geojupyter#18)
bdcc417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou Awaiting requested review from martinRenou

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brichet