Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayerTree changes are not getting saved into the file #24

Closed
martinRenou opened this issue Jul 2, 2024 · 5 comments
Closed

LayerTree changes are not getting saved into the file #24

martinRenou opened this issue Jul 2, 2024 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@martinRenou
Copy link
Member

See #22 (comment)

The changes on the tree are propagated to collaborators, but not save in the file. In a regular usage (new layer and layer included in tree), it works well because the new layer trigger the change on the server side. But if we only include a layer in the tree, it is not saved in the file. @davidbrochart any thoughts on this ?

@martinRenou martinRenou added the bug Something isn't working label Jul 2, 2024
@martinRenou martinRenou added this to the 1.0.0 milestone Jul 2, 2024
@martinRenou
Copy link
Member Author

Actually I can't reproduce, I can see the layerTree being properly updated:

Screencast.from.2024-07-02.09-35-34.mp4

@brichet
Copy link
Collaborator

brichet commented Jul 2, 2024

Yes, I observed this when doing some tests modifying only the layer tree, and not the layers and sources.
We will soon add a way to move the layers in the tree (without changing the layers and the sources), we'll see if the issue is still relevant.

@martinRenou
Copy link
Member Author

martinRenou commented Jul 2, 2024

I guess the kind of UI we'd want is being able to select multiple layers then right-click -> group selection, we'll need a context menu in your tree widget.

This context menu will be useful later for other commands.

@brichet
Copy link
Collaborator

brichet commented Jul 2, 2024

Yes, the context menu is a good option to create groups from layers.
We probably also want drag and drop to move the layers individually.

@martinRenou
Copy link
Member Author

Closing as it actually works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants