Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework object properties + format url properly #29

Merged
merged 19 commits into from
Jul 8, 2024
Merged

Rework object properties + format url properly #29

merged 19 commits into from
Jul 8, 2024

Conversation

martinRenou
Copy link
Member

Screencast.from.2024-07-03.11-14-37.mp4
Screencast.from.2024-07-03.11-32-27.mp4

@martinRenou martinRenou added the enhancement New feature or request label Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Binder 👈 Launch a Binder on branch martinRenou/jupytergis/rework_obj_properties

@martinRenou martinRenou requested a review from brichet July 4, 2024 09:52
@martinRenou martinRenou marked this pull request as ready for review July 4, 2024 09:52
brichet
brichet requested changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou.
I left some comments/question.

packages/base/src/mainview/mainview.tsx Show resolved Hide resolved
packages/base/src/panelview/formbuilder.tsx Outdated Show resolved Hide resolved
packages/base/src/panelview/formbuilder.tsx Outdated Show resolved Hide resolved
packages/base/src/panelview/formbuilder.tsx Outdated Show resolved Hide resolved
packages/base/src/panelview/objectproperties.tsx Outdated Show resolved Hide resolved
packages/base/src/panelview/objectproperties.tsx Outdated Show resolved Hide resolved
@brichet
Copy link
Collaborator

brichet commented Jul 5, 2024 •
edited
Loading

Just tested it and that's really great 🎉

@martinRenou
Copy link
Member Author

@brichet Thanks for the review! I updated according to your comments

brichet
brichet reviewed Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou for the update.
I added some comments below, but it can be in a follow up PR.

packages/base/src/panelview/objectproperties.tsx Show resolved Hide resolved
packages/base/src/panelview/objectproperties.tsx Outdated Show resolved Hide resolved
packages/schema/src/model.ts Outdated Show resolved Hide resolved
@martinRenou martinRenou self-assigned this Jul 5, 2024
@martinRenou martinRenou marked this pull request as draft July 5, 2024 14:49
@martinRenou martinRenou marked this pull request as ready for review July 8, 2024 09:10
brichet
brichet approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou

@brichet brichet merged commit f81bb2d into geojupyter:main Jul 8, 2024
9 checks passed
@martinRenou martinRenou deleted the rework_obj_properties branch July 8, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brichet brichet brichet approved these changes

Assignees

@martinRenou martinRenou

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @brichet