Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework custom raster layer creation #32

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Rework custom raster layer creation #32

merged 10 commits into from
Jul 10, 2024

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jul 9, 2024 •
edited
Loading

Screencast.from.2024-07-09.13-37-28.mp4

TODO:

  • figure out the variant issue as seen in the screencast
  • have a nice thumbnail for the custom raster box

@martinRenou martinRenou added the enhancement New feature or request label Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Binder 👈 Launch a Binder on branch martinRenou/jupytergis/rework_raster_layer_creation

@martinRenou
Copy link
Member Author

martinRenou commented Jul 9, 2024 •
edited
Loading

please update snapshots!!

@martinRenou martinRenou force-pushed the rework_raster_layer_creation branch from 1a6ce84 to 90d2fc7 Compare July 9, 2024 12:22
@martinRenou martinRenou force-pushed the rework_raster_layer_creation branch from 90d2fc7 to de14271 Compare July 9, 2024 13:41
@martinRenou martinRenou force-pushed the rework_raster_layer_creation branch from b7203fb to 8be4976 Compare July 9, 2024 15:44
@martinRenou martinRenou marked this pull request as ready for review July 9, 2024 16:03
@brichet
Copy link
Collaborator

brichet commented Jul 10, 2024 •
edited
Loading

Thanks @martinRenou

There is an issue with the disable status of the OK button of custom layer form.
When we add a URL parameter, the field is created with error (as expected) but the form can be validated. Then if we remove the parameter, the OK button is disabled.

Peek 2024-07-10 09-53

@martinRenou
Copy link
Member Author

@brichet I just pushed some commits fixing the issues you mentioned.

brichet
brichet approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @martinRenou

@brichet brichet merged commit b8d9511 into geojupyter:main Jul 10, 2024
9 checks passed
@martinRenou martinRenou deleted the rework_raster_layer_creation branch July 10, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brichet brichet brichet approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @brichet