Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clip calls wrong clip function #127

Closed
kai-tub opened this issue Dec 5, 2021 · 3 comments · Fixed by #149
Closed

clip calls wrong clip function #127

kai-tub opened this issue Dec 5, 2021 · 3 comments · Fixed by #149

Comments

@kai-tub
Copy link

kai-tub commented Dec 5, 2021

Hey all.

I am loving the work on this project!
I've stumbled upon a bug and wanted you to let you know about it.
I don't know if it is actually worth "fixing".
If one calls .clip on a geopandas dask dataframe object, the dask clip function (clipping values between min/max is called)

To reproduce:

import geopandas
import dask_geopandas

path_to_data = geopandas.datasets.get_path("nybb")
gdf = geopandas.read_file(path_to_data)
ddf = dask_geopandas.from_geopandas(gdf, npartitions=2)
ddf.clip(gdf.geometry[0])
@martinfleis
Copy link
Member

Hi, this is not a bug strictly speaking. But it is surely something worth fixing. We have introduced clip as a method on geopandas in the last release and this API change has not propagated to dask-geopandas yet. The same applies to sjoin and overlay, in fact.

We should expose sjoin and clip as methods here as well, it just hasn't been done yet.

@kai-tub
Copy link
Author

kai-tub commented Dec 6, 2021

I see.
I am quite interested in the development of the package and would like to contribute a bit if possible.
I have some experience with Dask and use Geopandas, but am not too familiar with the internals.
Maybe some issues could be marked as Good first issue?

I know this is an alpha level library, but maybe there are some small tasks I can help out with :)

@martinfleis
Copy link
Member

@kai-tub Sorry for a slow response!

Any help is welcome, I am just not sure if there's a lot good first issues at the moment. One that comes to my mind is mentioned in #130:

covers and covered_by are 2 missing predicates that should be trivial to add here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants