Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-thread support for geo-types using Rayon #1257

Open
urschrei opened this issue Nov 4, 2024 · 0 comments · May be fixed by #1265
Open

Multi-thread support for geo-types using Rayon #1257

urschrei opened this issue Nov 4, 2024 · 0 comments · May be fixed by #1265

Comments

@urschrei
Copy link
Member

urschrei commented Nov 4, 2024

#1246 proposes a multi-threaded variant of the unary union algorithm. Out of the box, this works on containers that impl IntoParallelIterator<Item = &'a Boppable>. MultiPolygon doesn't, because geo-types has very few dependencies, let alone Rayon. However, if we had optional Rayon support (and enabled it when it was enabled for geo) we could call it like this:

let poly_union = AllowMultithreading(&parcel_multipolygon).unary_union()

Instead of like this:

let poly_union = AllowMultithreading(&parcel_multipolygon.0).unary_union()

Which isn't very nice and forces us to use the exposed-implementation-detail .0 syntax.

@urschrei urschrei linked a pull request Nov 6, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant