From 25eb351db6b20f4173d3c58cee17edf79448da88 Mon Sep 17 00:00:00 2001 From: Bob Yantosca Date: Tue, 12 Nov 2024 14:18:05 -0500 Subject: [PATCH] Fix errors in benchmark_categories.yml gcpy/benchmark/modules/benchmark_categories.yml - Moved HACTA, HCOOH, MAP, RCOOH to "Secondary_Organics:Acids" - Moved GLYC, GLYX, RCHO to "Secondary_Organics:Aldehydes" - Added TLFUONE to "Secondary_Organics:Other" CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca --- CHANGELOG.md | 1 + .../benchmark/modules/benchmark_categories.yml | 18 ++++++++++-------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e48193b..1f4c9f0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), - Fixed formatting error in `.github/workflows/stale.yml` that caused the Mark Stale Issues action not to run - Now flag differences greater than +/- 10% in benchmark timing table outputs - Fixed error in computation of dynamic ratio plot min & max values in `plot/six_plot.py` +- Fixed erroneous species classification in `gcpy/benchmark/modules/benchmark_categories.yml` ### Removed - Removed `gcpy/benchmark/modules/species_database.yml` file and corresponding code pointing to this diff --git a/gcpy/benchmark/modules/benchmark_categories.yml b/gcpy/benchmark/modules/benchmark_categories.yml index 04ca479..0abb78b 100644 --- a/gcpy/benchmark/modules/benchmark_categories.yml +++ b/gcpy/benchmark/modules/benchmark_categories.yml @@ -70,7 +70,7 @@ FullChemBenchmark: - HCl - Halons - HCFCs - - OClO + - OClO Iodine: Iodine: - Iy @@ -122,7 +122,7 @@ FullChemBenchmark: - O3 - CO - OH - - NOx + - NOx Primary_Organics: Alcohols: - EOH @@ -186,13 +186,20 @@ FullChemBenchmark: Secondary_Organics: Acids: - ACTA + - HACTA + - HCOOH + - MAP + - RCOOH Aldehydes: - ACR - ALD2 - BALD - CH2O + - GLYC + - GLYX - HPALDs - MACR + - RCHO Epoxides: - IEPOX Ketones: @@ -204,13 +211,8 @@ FullChemBenchmark: - ISOPN Other: - FURA - - GLYC - - GLYX - - HCOOH - - RCOOH - - MAP - PHEN - - RCHO + - TLFUONE Peroxides: - ETHP - MP