Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ force the UV verification #27

Merged
merged 1 commit into from
Mar 12, 2024
Merged

♻️ force the UV verification #27

merged 1 commit into from
Mar 12, 2024

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Mar 12, 2024

The library is developed to verify passkeys. The UV is enforced for passkeys, meaning it is not necessary to be passed as a parameter. Starting from this point, WebAuthn flow that didn't verify the user will fail the verification.

The library is developed to verify passkeys. The
UV is a enforced for passkeys, meaning it is not
necessary to be passed as a parameter.
Starting from this point, WebAuthn flow that didn't
verified the user will fail the verification.
@qd-qd qd-qd self-assigned this Mar 12, 2024
Copy link

Changes to gas cost

Generated at commit: efbdc0662a5fde0b8e6b4f6ed9e97797c062c78e, compared to commit: 1ebd210c69a7315d0828b5f9d2669b68dc670dd8

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
WebAuthnWrapper _generateMessage
verify
-2,427 ✅
+928 ❌
-45.70%
+0.39%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
WebAuthnWrapper 1,441,120 (-15,085) _generateMessage
verify
1,028 (-4,252)
237,743 (+928)
-80.53%
+0.39%
2,884 (-2,427)
237,743 (+928)
-45.70%
+0.39%
3,439 (-1,841)
237,743 (+928)
-34.87%
+0.39%
7,008 (+1,537)
237,743 (+928)
+28.09%
+0.39%
771 (+765)
1 (0)

@qd-qd qd-qd merged commit b682c71 into main Mar 12, 2024
4 checks passed
@qd-qd qd-qd deleted the refacto/make-uv-constant branch March 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant