-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: "Copy Invoice" uncaught exception in "Buy an Instant Channel" #56
Comments
In what setup are you running the app? it's likely on a non https setup? @im-adithya you had a workaround for this case, didn't you? can you add that to bitcoin-connect, too? |
Yes, was a non-http setup. Closing this as it might be not be worth fixing this edge case. |
actually it would be good to solve. if you run it at home or just on a private IP then this should also work. |
@im-adithya should have fixed this about a week ago in getAlby/nostr-wallet-connect-next#440 @MegalithicBTC did you have the latest changes? |
Yeah, please let us know if it breaks even after the update! |
@im-adithya This doesn't work on Firefox on local non https domains. I've prepared a PR that seems to work: |
Fixes #56 Tested on a local domain.
Please see screenshot below.
I would like to try to fix this issue, however I could use a little bit of direction here.
Error is happening here:
https://github.com/getAlby/bitcoin-connect/blob/b1306775814135ff7fe14e0e4758d60286321cf1/src/components/pages/bc-send-payment.ts#L213
Would you suggest that I dig into the
bitcoin-connect
package to try to debug this issue? Or are we usingbitcoin-connect
incorrectly?The text was updated successfully, but these errors were encountered: