Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "Copy Invoice" uncaught exception in "Buy an Instant Channel" #56

Closed
MegalithicBTC opened this issue Jun 17, 2024 · 6 comments · Fixed by #242
Closed

Bug: "Copy Invoice" uncaught exception in "Buy an Instant Channel" #56

MegalithicBTC opened this issue Jun 17, 2024 · 6 comments · Fixed by #242

Comments

@MegalithicBTC
Copy link

Please see screenshot below.

I would like to try to fix this issue, however I could use a little bit of direction here.

Error is happening here:

https://github.com/getAlby/bitcoin-connect/blob/b1306775814135ff7fe14e0e4758d60286321cf1/src/components/pages/bc-send-payment.ts#L213

Would you suggest that I dig into the bitcoin-connect package to try to debug this issue? Or are we using bitcoin-connect incorrectly?

copy-invoice-failure

@bumi
Copy link
Contributor

bumi commented Jun 19, 2024

In what setup are you running the app? it's likely on a non https setup?

@im-adithya you had a workaround for this case, didn't you? can you add that to bitcoin-connect, too?

@MegalithicBTC
Copy link
Author

Yes, was a non-http setup. Closing this as it might be not be worth fixing this edge case.

@bumi
Copy link
Contributor

bumi commented Jun 20, 2024

actually it would be good to solve. if you run it at home or just on a private IP then this should also work.

@bumi bumi reopened this Jun 20, 2024
@rolznz
Copy link
Contributor

rolznz commented Jun 20, 2024

@im-adithya should have fixed this about a week ago in getAlby/nostr-wallet-connect-next#440

@MegalithicBTC did you have the latest changes?

@im-adithya
Copy link
Member

Yeah, please let us know if it breaks even after the update!

@im-adithya im-adithya transferred this issue from getAlby/nostr-wallet-connect-next Jul 5, 2024
@reneaaron
Copy link
Contributor

@im-adithya This doesn't work on Firefox on local non https domains. I've prepared a PR that seems to work:

#242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants