Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset router does not work with VSS enabled #818

Closed
rolznz opened this issue Nov 21, 2024 · 4 comments · Fixed by #912
Closed

Reset router does not work with VSS enabled #818

rolznz opened this issue Nov 21, 2024 · 4 comments · Fixed by #912
Assignees
@rdmitr
Milestone
v1.13.0

Comments

@rolznz
Copy link
Contributor

rolznz commented Nov 21, 2024 •
edited
Loading

We directly try to write to the sqlite DB rather than writing to the ldk-node KV store which does nothing if we don't even use sqlite
@rolznz rolznz added this to the v1.11.0 milestone Nov 21, 2024
@rolznz rolznz modified the milestones: v1.11.0, v1.12.0 Nov 27, 2024
@rdmitr
Copy link
Collaborator

rdmitr commented Nov 28, 2024

PR is up: getAlby/ldk-node#56

@rolznz rolznz modified the milestones: v1.12.0, v1.13.0 Dec 17, 2024
@rolznz
Copy link
Contributor Author

rolznz commented Dec 18, 2024

@rdmitr any chance you can implement the alby hub side of this too?

@rdmitr
Copy link
Collaborator

rdmitr commented Dec 18, 2024

Definitely!

@rdmitr rdmitr linked a pull request Dec 20, 2024 that will close this issue
feat: implement router reset through the LDK-node Builder #912
Merged
@rdmitr
Copy link
Collaborator

rdmitr commented Dec 20, 2024

@rolznz PR is up, could you please take a look? #912

@rolznz rolznz mentioned this issue Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdmitr rdmitr

Labels
None yet
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

feat: implement router reset through the LDK-node Builder getAlby/hub
2 participants
@rdmitr @rolznz