Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetBrains sign in via license key #506

Closed
brikelly opened this issue Dec 6, 2023 · 1 comment · Fixed by #508
Closed

JetBrains sign in via license key #506

brikelly opened this issue Dec 6, 2023 · 1 comment · Fixed by #508
Assignees
Labels
enhancement New feature or request released

Comments

@brikelly
Copy link
Contributor

brikelly commented Dec 6, 2023

This task is to create an equivalent of this PR for VS Code.

The desired UX is as follows:

  • Users who cannot use GitHub or GitLab to sign in can instead enter a license key. This key will be retrieved through other means, e.g. by contacting our support team.
  • After installing the AppMap plugin from the marketplace, a new menu option will be available under Tools -> AppMap called Enter license key. This can be placed at the bottom, in the third section of items:
    Image
  • Once the user clicks on this menu item, they are presented with a modal dialog box with title "Enter your AppMap license key" and with a single text entry box named "license key". If they click the "OK" button then the auth checks occur.
  • The auth checks may require opening a browser similar to how the existing sign in is done.
  • If the key verification completes successfully, the "Sign In" panel should disappear and be replaced with the normal AppMap functionality, just as the existing GitHub/Lab flow does. A notification should also be displayed saying "Logged into AppMap".
  • If the key verification fails, a notification should be displayed saying "License key verification failed".

Notes:

  • If the user is already logged in with GitHub/Lab, entering a license key will replace their login with the new license key login instead. There is no need to warn the user that they're already logged in with another method.
@appland-release
Copy link
Contributor

🎉 This issue has been resolved in version 0.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants