Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests fail on master because of updates to Werkzeug and urllib3 #237

Closed
apotterri opened this issue May 8, 2023 · 2 comments · Fixed by #240
Closed

tests fail on master because of updates to Werkzeug and urllib3 #237

apotterri opened this issue May 8, 2023 · 2 comments · Fixed by #240
Assignees
@apotterri
Labels
appmap-python bug Something isn't working

Comments

@apotterri
Copy link
Contributor

One (or more) of the test dependencies have changed, and many tests now fail, as seen in this build: https://app.travis-ci.com/github/getappmap/appmap-python
@apotterri apotterri self-assigned this May 8, 2023
@apotterri apotterri added bug Something isn't working appmap-python labels May 8, 2023
@apotterri
Copy link
Contributor Author

apotterri commented May 9, 2023 •
edited
Loading

The latest versions of Flask, in both the v2.2 and v2.3 release streams, specify their dependency on Werkzeug using '>='. This means installing the current version of Flask will pick up a 2.3.x version of Werkzeug, and that breaks appmap-python's Flask integration.

@apotterri apotterri closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2023
@apotterri apotterri reopened this May 9, 2023
@apotterri
Copy link
Contributor Author

apotterri commented May 9, 2023 •
edited
Loading

Oops, maybe better to leave it open.

We need to support v2.3.x of Werkzeug (see above). And we need to fix some other test failures by pinning urllib3 until #239 is fixed.

@apotterri apotterri changed the title tests fail on master tests fail on master because of updates to Werkzeug and urllib3 May 9, 2023
@apotterri apotterri mentioned this issue May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apotterri apotterri

Labels
appmap-python bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Werkzeug v2.3, pin to urllib3 v1 getappmap/appmap-python
1 participant
@apotterri