Supportable JS project dependencies are detected correctly #711
Assignees
Labels
Comments
|
What does this mean?
…On Sun, Jun 4, 2023 at 8:18 PM Brian Kelly ***@***.***> wrote:
—
Reply to this email directly, view it on GitHub
<#711>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVC6ZYF35U7QTI2TCRRFTXJUQXDANCNFSM6AAAAAAY2IKUBI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Yes, do we have an example? |
brikelly
changed the title
|
@dividedmind not to my mind, but I know it has been reported. I believe correct detection of Next.js / Express is particularly difficult due to this issue, if that helps. |
|
We need to find Express, jest and mocha in package-lock.json and yarn.lock. That’s all it is! |
|
Corresponding intellij issue: getappmap/appmap-intellij-plugin#294 |
dividedmind
added a commit
that referenced
this issue
Jun 7, 2023
Sometimes supported web or test frameworks are not direct dependencies of the project but instead are transitively pulled by another one; this is especially common with express.js. AppMap should still work correctly with most of these projects. To make this use case easier, make sure to look in package-lock.json and yaml.lock in the project support detection in addition to package.json. Fixes #711
dividedmind
added a commit
that referenced
this issue
Jun 9, 2023
Sometimes supported web or test frameworks are not direct dependencies of the project but instead are transitively pulled by another one; this is especially common with express.js. AppMap should still work correctly with most of these projects. To make this use case easier, make sure to look in package-lock.json and yaml.lock in the project support detection in addition to package.json. Fixes #711
dividedmind
added a commit
that referenced
this issue
Jun 9, 2023
Sometimes supported web or test frameworks are not direct dependencies of the project but instead are transitively pulled by another one; this is especially common with express.js. AppMap should still work correctly with most of these projects. To make this use case easier, make sure to look in package-lock.json and yaml.lock in the project support detection in addition to package.json. Fixes #711
appland-release
pushed a commit
that referenced
this issue
Jun 15, 2023
# [0.86.0](v0.85.0...v0.86.0) (2023-06-15) ### Features * add run and test configs for java users ([8ffacbe](8ffacbe)) * command to download latest java agent jar ([8cc8966](8cc8966)) * commands to update launch and test configs ([e5e1aeb](e5e1aeb)) * download latest java agent jar file ([5e8c694](5e8c694)) * Look for JavaScript dependencies in lockfiles ([face65f](face65f)), closes [#711](#711)
|
🎉 This issue has been resolved in version 0.86.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our installer is not correctly detecting bona fide supportable JS projects. It should additionally look in files like
yarn.lockorpackage-lock.json.The text was updated successfully, but these errors were encountered: