Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Click here" of "Add AppMap to your project" does nothing #939

Open
jansorg opened this issue Apr 9, 2024 · 1 comment · May be fixed by #963
Open

"Click here" of "Add AppMap to your project" does nothing #939

jansorg opened this issue Apr 9, 2024 · 1 comment · May be fixed by #963

Comments

@jansorg
Copy link

jansorg commented Apr 9, 2024

Testing latest AppMap VSCode plugin with a fresh checkout of https://github.com/junit-team/junit5

The "click here" link in the screenshot isn't doing anything when I click it.
image
@zermelo-wisen zermelo-wisen linked a pull request May 8, 2024 that will close this issue
Draft
@zermelo-wisen
Copy link
Collaborator

@jansorg, I was able to reproduce the (similar) problem with these steps:

  • Clone junit5 repo
  • Click "click here" to add configs
  • Open launch.json or settings.json
  • Delete them from the Source Control section ("Discard Changes") while keeping launch.json open in the editor
  • Click "click here" again

Files will be added but launch.json will be empty and "Add AppMap to your project" will keep showing the warning, which is correct, since launch.json is not added properly.

What were your steps to produce the problem?

add-test-debug-config.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ensure files closed before adding test and debug config getappmap/vscode-appland
2 participants
@jansorg @zermelo-wisen