From d708cb96158671de55688d5db3bdecf9eb033b18 Mon Sep 17 00:00:00 2001 From: Adam Trotta Date: Wed, 29 Nov 2023 15:03:35 -0500 Subject: [PATCH 1/3] test: Drop specific vs code version number for testing --- test/integrationTest.ts | 2 +- test/system/src/app.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/test/integrationTest.ts b/test/integrationTest.ts index 380a44c6..234c0a74 100644 --- a/test/integrationTest.ts +++ b/test/integrationTest.ts @@ -86,7 +86,7 @@ async function integrationTest() { const extensionDevelopmentPath = resolve(__dirname, '..'); const userDataDir = resolve(__dirname, '../.vscode-test/user-data'); - const vscodeExecutablePath = await downloadAndUnzipVSCode('1.81.1'); + const vscodeExecutablePath = await downloadAndUnzipVSCode(); const [cliPath] = resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath); if (process.env.TEST_YARN_INSTALL !== 'false') { diff --git a/test/system/src/app.ts b/test/system/src/app.ts index 0348d124..239a7907 100644 --- a/test/system/src/app.ts +++ b/test/system/src/app.ts @@ -30,7 +30,6 @@ interface LaunchOptions { export async function downloadCode(): Promise { return await downloadAndUnzipVSCode({ - version: '1.81.1', reporter: new ConsoleReporter(false), }); } From 12764d0f6be54bd8cc7111c001c73d5b1a816318 Mon Sep 17 00:00:00 2001 From: Adam Trotta Date: Wed, 29 Nov 2023 15:15:05 -0500 Subject: [PATCH 2/3] fixup! test: Drop specific vs code version number for testing --- test/integrationTest.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/integrationTest.ts b/test/integrationTest.ts index 234c0a74..a471bfad 100644 --- a/test/integrationTest.ts +++ b/test/integrationTest.ts @@ -113,8 +113,6 @@ async function integrationTest() { extensionDevelopmentPath, '--user-data-dir', userDataDir, - '--install-extension', - 'appland.appmap', '--force', '--password-store=basic', ], From 950b8a78774a0092440c2b8c7a282bacf8bc78b9 Mon Sep 17 00:00:00 2001 From: Adam Trotta Date: Wed, 29 Nov 2023 15:23:22 -0500 Subject: [PATCH 3/3] fixup! test: Drop specific vs code version number for testing --- test/integrationTest.ts | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/test/integrationTest.ts b/test/integrationTest.ts index a471bfad..40e01ed4 100644 --- a/test/integrationTest.ts +++ b/test/integrationTest.ts @@ -106,21 +106,10 @@ async function integrationTest() { ); } - cp.spawnSync( - cliPath, - [ - '--extensions-dir', - extensionDevelopmentPath, - '--user-data-dir', - userDataDir, - '--force', - '--password-store=basic', - ], - { - encoding: 'utf-8', - stdio: 'inherit', - } - ); + cp.spawnSync(cliPath, ['--user-data-dir', userDataDir, '--force', '--password-store=basic'], { + encoding: 'utf-8', + stdio: 'inherit', + }); const runTests = async (testFile: string, workspaceDir: string) => { startTime = new Date();