Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin support #570

Open
morgante opened this issue Oct 30, 2024 · 8 comments · May be fixed by #573
Open

Kotlin support #570

morgante opened this issue Oct 30, 2024 · 8 comments · May be fixed by #573
Labels
💎 Bounty language

Comments

@morgante
Copy link
Contributor

We would like to support Kotlin as a language for matching against.

Review this guide and join us on Discord to discuss.

Acceptance criteria

  1. Working grammar + language support
  2. At least 10 test cases, including rewrites and metavariables.
@morgante
Copy link
Contributor Author

/bounty $250

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Oct 30, 2024 •
edited
Loading

💎 $250 bounty • Grit

Steps to solve:

  1. Start working: Comment /attempt #570 with your implementation plan
  2. Submit work: Create a pull request including /claim #570 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to getgrit/gritql!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @Alex-ley-scrub Oct 30, 2024, 6:58:59 PM #573

@Alex-ley-scrub
Copy link
Contributor

Alex-ley-scrub commented Oct 30, 2024 •
edited by algora-pbc bot
Loading

/attempt #570

Algora profile Completed bounties Tech Active attempts Options
@Alex-ley-scrub 4 grit bounties
Rust
﹟539
 Cancel attempt

@morgante
Copy link
Contributor Author

/assign @Alex-ley-scrub

Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Oct 31, 2024
@Alex-ley-scrub
feat(kotlin): add 'tree-sitter-kotlin' submodule
7da83bd 
fixes getgrit#570
@Alex-ley-scrub Alex-ley-scrub mentioned this issue Oct 31, 2024
Merged
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Oct 31, 2024
@Alex-ley-scrub
feat(kotlin): update "vendor/tree-sitter-gritql" submodule commit and…
724f6ef 
… add `simple_kotlin()` test

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 2, 2024
@Alex-ley-scrub
feat: copy kotlin grammar.js into 'metavariable-grammars/kotlin-metav…
7b921db 
…ariable-grammar.js'

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 8, 2024
@Alex-ley-scrub
fix(kotlin-metavariable-grammar.js): add grit_metavariable in a bun…
ba69382 
…ch of places to enable metavariable substitution

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 8, 2024
@Alex-ley-scrub
fix: copy "resources/language-submodules/tree-sitter-kotlin/" -> "res…
8e6ef11 
…ources/language-metavariables/tree-sitter-kotlin/"

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 8, 2024
@Alex-ley-scrub
fix(kotlin-metavariable-grammar.js): add missing grit_metavariable co…
cd2fe7d 
…nflicts

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 8, 2024
@Alex-ley-scrub
fix(language-metavariables/tree-sitter-kotlin): update with 'resource…
3a706e6 
…s/edit_grammars.mjs' script

fixes getgrit#570
@Alex-ley-scrub Alex-ley-scrub linked a pull request Nov 8, 2024 that will close this issue
Open
14 tasks
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Nov 8, 2024 •
edited
Loading

💡 @Alex-ley-scrub submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 9, 2024
@Alex-ley-scrub
feat(kotlin): add kotlin.rs with impl Language for Kotlin and add `…
07f0922 
…PatternLanguage::Kotlin`

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 9, 2024
@Alex-ley-scrub
fix(patterns_directory.rs): add kotlin to the PatternsDirectory str…
766a15f 
…uct and add it to all match statements

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 9, 2024
@Alex-ley-scrub
fix(kotlin): add kotlin to missing enums and match statements in crat…
84d1434 
…es/lsp and crates/wasm-bindings

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 15, 2024
@Alex-ley-scrub
fix(kotlin-metavariable-grammar): try to implement it more like the p…
3c8b058 
…ython-metavariable-grammar with fewer $.grit_metavariable but at 'higher' level

fixes getgrit#570
@urbit-pilled
Copy link
Contributor

Hello @Alex-ley-scrub do you still plan on completing this? I see that you requested a review but your test cases are failing.

@Alex-ley-scrub
Copy link
Contributor

@urbit-pilled yeah I’ll be completing it. I’ve been chatting to @morgante on Discord. I was waiting for some tips from him regarding where to look. Essentially, I’ve done ~90+% of the work and it looks like the metavariable grammar is working fine etc. but then some snippets don’t match (hence broken tests - the tests I added to make sure the snippets where matching correctly). He’s told me where to have a look now so I can restart the work.

@urbit-pilled
Copy link
Contributor

urbit-pilled commented Dec 5, 2024 •
edited
Loading

Ok, good to hear @Alex-ley-scrub. If you need help you can message me on discord. (I'm in the Algora and GritQL server)

In my experience, this task is more complex than it initially appears. A few months ago, I added PHP and Ruby to Grit for a much larger amount, and I initially underestimated the difficulty of the task. As I began working on it, I encountered numerous problems along the way.

You can take a look at my fork if you want to see a kotlin branch that passes a few test cases.

Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
feat(kotlin): add 'tree-sitter-kotlin' submodule
2862d27 
fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
feat(kotlin): update "vendor/tree-sitter-gritql" submodule commit and…
f57def5 
… add `simple_kotlin()` test

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
feat: copy kotlin grammar.js into 'metavariable-grammars/kotlin-metav…
b7e617d 
…ariable-grammar.js'

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
fix(kotlin-metavariable-grammar.js): add grit_metavariable in a bun…
219d8be 
…ch of places to enable metavariable substitution

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
fix: copy "resources/language-submodules/tree-sitter-kotlin/" -> "res…
56fd085 
…ources/language-metavariables/tree-sitter-kotlin/"

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
fix(kotlin-metavariable-grammar.js): add missing grit_metavariable co…
5d1dd0e 
…nflicts

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
fix(language-metavariables/tree-sitter-kotlin): update with 'resource…
22a5a8f 
…s/edit_grammars.mjs' script

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
feat(kotlin): add kotlin.rs with impl Language for Kotlin and add `…
28f3233 
…PatternLanguage::Kotlin`

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
fix(patterns_directory.rs): add kotlin to the PatternsDirectory str…
48b276b 
…uct and add it to all match statements

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
fix(kotlin): add kotlin to missing enums and match statements in crat…
eeab266 
…es/lsp and crates/wasm-bindings

fixes getgrit#570
Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Jan 6, 2025
@Alex-ley-scrub
fix(kotlin-metavariable-grammar): try to implement it more like the p…
62e5ec8 
…ython-metavariable-grammar with fewer $.grit_metavariable but at 'higher' level

fixes getgrit#570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 570 kotlin support Alex-ley-scrub/gritql
3 participants
@morgante @Alex-ley-scrub @urbit-pilled