-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple hostnames #113
Comments
Hey, @camertron can I please pick this up? |
@madlad33 absolutely, thank you! |
Just a heads-up, someone with the handle @andersmarkc submitted and immediately closed two pull requests that appear to be addressing this issue. Not sure what's going on there. Perhaps consider coordinating with them? |
@camertron was trying to create a pull request to my own fork and f it up 2 times my bad, @madlad33 have a go at it if you fix it will save me a lot of time 👍 |
Sure @andersmarkc, thanks! |
Sick @madlad33, thanks for picking up the issue. Please ping me whenever you have a PR 👍🏻 |
Kuby only supports configuring a single hostname for an application, but as far as I know there's no actual Kubernetes-enforced limit on the number of hostnames allowed per ingress object. I propose using the existing
hostname
method to add hostnames to a list instead of the current behavior which simply replaces any previously configured hostname. In other words:See #112
The text was updated successfully, but these errors were encountered: