Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple hostnames #113

Open
camertron opened this issue Sep 22, 2022 · 6 comments
Open

Add support for multiple hostnames #113

camertron opened this issue Sep 22, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@camertron
Copy link
Member

Kuby only supports configuring a single hostname for an application, but as far as I know there's no actual Kubernetes-enforced limit on the number of hostnames allowed per ingress object. I propose using the existing hostname method to add hostnames to a list instead of the current behavior which simply replaces any previously configured hostname. In other words:

add_plugin :rails_app do
  hostname 'whatever.mydomain.com'
  hostname 'whatever2.mydomain.com'
end

See #112

@camertron camertron added the enhancement New feature or request label Sep 22, 2022
@madlad33
Copy link

madlad33 commented Oct 5, 2022

Hey, @camertron can I please pick this up?

@camertron
Copy link
Member Author

@madlad33 absolutely, thank you!

@camertron
Copy link
Member Author

Just a heads-up, someone with the handle @andersmarkc submitted and immediately closed two pull requests that appear to be addressing this issue. Not sure what's going on there. Perhaps consider coordinating with them?

@andersmarkc
Copy link

@camertron was trying to create a pull request to my own fork and f it up 2 times my bad, @madlad33 have a go at it if you fix it will save me a lot of time 👍

@madlad33
Copy link

madlad33 commented Oct 5, 2022

Sure @andersmarkc, thanks!

@NikoDyring
Copy link

Sure @andersmarkc, thanks!

Sick @madlad33, thanks for picking up the issue. Please ping me whenever you have a PR 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants