feat(auth): Add user last login informations #3242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
reviewed
Feb 24, 2025
nudded
reviewed
Feb 24, 2025
| @@ -19,20 +27,26 @@ class User < ApplicationRecord | |||
| has_many :subscriptions, through: :customers | |||
|
|
|||
| validates :email, presence: true | |||
| validates :password, presence: true | |||
| validates :password, presence: true, on: :create | |||
There was a problem hiding this comment.
We don't want to allow empty passwords on update I think?
There was a problem hiding this comment.
this will not override password if its nil? (since the password digest should stay)
There was a problem hiding this comment.
the only other solution we have, is to disable validations for the update on the touch method
There was a problem hiding this comment.
how can this validation fail on touch?
There was a problem hiding this comment.
it always fail and say that the password is empty, we do not have any password field in DB thats why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last_login_atandlast_login_methodpasswordonly on users creation for validations (this made us unable to update a user)