-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version conflicts to entity updates #511
Comments
My current thinking is that we could implement this as two columns:
|
Frontend needs conflict counts in multiple places. For #505 and #507, Frontend also needs the diffs of the conflicting entity versions relative to their base version ("author's view"). The current diffs endpoint compares entity versions sequentially ("Central's view"), which Frontend still needs. But Frontend now also needs a way to diff conflicting entity versions relative to their base version. In addition, Frontend needs to know for each conflicting entity version whether it is a soft conflict or a hard conflict. In the case of a hard conflict, it needs to know which properties conflict. (I guess a soft conflict is just the case where the list of conflicting properties is empty.) For #505, Frontend also needs to receive data about the "known good" version and all base versions. |
I'm copying this note from @lognaturel to here because its relevant to how we think about conflicts:
There's ongoing discussion in slack but I'll summarize it all here in this issue once we get to a decision. |
Depends on #509
entities
orentity_defs
table?)Should be able to compute
API changes should enable the following frontend PRs:
#500
#502
#503
#504
The text was updated successfully, but these errors were encountered: