Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text for Convert Pending Submissions or come up with new approach #837

Open
ktuite opened this issue Dec 9, 2024 · 2 comments
Open
Labels
entities Multiple Encounter workflows

Comments

@ktuite
Copy link
Member

ktuite commented Dec 9, 2024

In this project, I have 2 forms (registration and monitoring), one dataset, and one submission to the monitoring form. The monitoring (update) submission is in the backlog because it was created offline and the registration (create) submission was not sent.

https://staging.getodk.cloud/#/projects/133

Image

Image

When I go to toggle the dataset to not require approval and reprocess all pending submissions, it shows this message indicating 1 submission that will be used to create an entity. This is misleading because this submission wont create an entity, even if force-processed, unless the dataset setting is changed before the force-processing occurs.

Image

The messaging in this popup is from a time when we only had entity creates and is confusing and misleading now.

The "convert all pending submissions to entities now" functionality is also really hard to reason about now that we have offline entity updates and force processing. Does it still have a place? Could we consider removing it?

@ktuite ktuite moved this to 🕒 backlog in ODK Central Dec 9, 2024
@ktuite ktuite added the entities Multiple Encounter workflows label Dec 9, 2024
@matthew-white
Copy link
Member

@lognaturel suggests: Change title of option to something like: "Convert all pending create Submissions"

@lognaturel
Copy link
Member

lognaturel commented Jan 9, 2025

I do think we could make this more true and understandable by changing the text to

Convert all pending Submissions that create Entities
Change the setting and create Entities from any Submissions that indicate Entity creation and have not been Approved or Rejected.

This functionality adds convenience but I doubt it's commonly used. The same effect can be achieved by approving all pending submissions before toggling the setting. I think if it's a painful option to maintain we could remove it, even without first adding analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entities Multiple Encounter workflows
Projects
Status: 🕒 backlog
Development

No branches or pull requests

3 participants