Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a repeat has no label, improve the add repeat dialog text #6439

Open
lognaturel opened this issue Oct 2, 2024 · 8 comments · May be fixed by #6459
Open

If a repeat has no label, improve the add repeat dialog text #6439

lognaturel opened this issue Oct 2, 2024 · 8 comments · May be fixed by #6459
Assignees
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =)

Comments

@lognaturel
Copy link
Member

lognaturel commented Oct 2, 2024

  • Replace "Do not add" with "Cancel"
  • Use title font for prompt text, otherwise keep the prompt text the same (quotes and question mark)
  • If repeat has no label (label is null), use special text "Add another?" instead of using null

https://forum.getodk.org/t/repeat-groups-add-null-repeat-dialogue-and-remove-repeat/49836

@karntrehan
Copy link

Hie @lognaturel, is this a good-first-issue? I would love to contribute some fixes to collect but currently the list for good first issues seems to be very limited: good first issue.

Do let me know how I can contribute.

@lognaturel
Copy link
Member Author

Thanks for your interest, @karntrehan! Yes, this should be a straightforward one to take on.

@alyblenkin what do you think of changing the text in the case of a repeat without a label from "Add "null"?" to "Add another?" and changing the "Do not add" button to "Cancel" for now?

@alyblenkin
Copy link
Collaborator

Welcome @karntrehan!

@lognaturel - "Add another" and "Cancel" makes a lot more sense here! For the option to remove a repeat, it would be strange to remove from tapping on the add action, so we may need to come back to that.

I don't think the support text helps too much here, but I played around with that just to see.

Screenshot 2024-10-10 at 1 53 03 PM

@lognaturel
Copy link
Member Author

lognaturel commented Oct 10, 2024

it would be strange to remove from tapping on the add action, so we may need to come back to that.

Agreed!

The common case is going to be something like Add "Person" or Add "sick dog" or something like that if the form creator has specified a label for the repeat. I think we should leave that alone and only add a new case for when the label is null. Given that, do you think we should increase the font size and make the question into more of a title as you have in the mockups? The length of the label is unknown. For example it could be Add "country representative who is responsible for local healthcare decisions".

Agreed we don't need two lines of text.

@alyblenkin
Copy link
Collaborator

alyblenkin commented Oct 10, 2024

Given that, do you think we should increase the font size and make the question into more of a title as you have in the mockups? The length of the label is unknown. For example it could be Add "country representative who is responsible for local healthcare decisions".

Yes, I thought about longer titles. I wish we had a limit for labels to make it easier to read, but this is much larger piece of work, and not the actual pain point here :)

Despite the fact that in some cases titles can be lengthy, I still think we should use the title font size because it creates a stronger hierarchy of information. Here is what it would look like with your example, which is very long/not ideal, but I think better than using the body text, which seems too small for a prompt. What do you think?

Screenshot 2024-10-10 at 2 28 36 PM

@lognaturel
Copy link
Member Author

Sounds good to me! I have updated the issue description.

@lognaturel lognaturel added good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) and removed needs design labels Oct 10, 2024
@karntrehan
Copy link

I guess the code powering this flow is here:

alertDialog.setMessage(context.getString(org.odk.collect.strings.R.string.add_repeat_question,

I will also need to update the tests here:

return clickOnTextInDialog(org.odk.collect.strings.R.string.dont_add_repeat, destination);

I have asked the OP for a sample form to test my fix here. @lognaturel would be great if you could help with that as well, else I can try creating the form at my end.

@seadowg seadowg assigned seadowg and karntrehan and unassigned seadowg Oct 15, 2024
karntrehan added a commit to karntrehan/collect that referenced this issue Oct 16, 2024
@karntrehan
Copy link

karntrehan commented Oct 16, 2024

Folks the PR has been raised. Here: #6459

I have also fixed a few readme issues.

@karntrehan karntrehan linked a pull request Oct 16, 2024 that will close this issue
6 tasks
karntrehan added a commit to karntrehan/collect that referenced this issue Oct 16, 2024
karntrehan added a commit to karntrehan/collect that referenced this issue Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =)
Projects
Status: in progress
Development

Successfully merging a pull request may close this issue.

4 participants