Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zstd for file uploads #2339

Open
szokeasaurusrex opened this issue Jan 13, 2025 · 0 comments
Open

Use zstd for file uploads #2339

szokeasaurusrex opened this issue Jan 13, 2025 · 0 comments

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Jan 13, 2025

zstd compression offers faster compression with better compression ratios compared to gzip, what we currently use for file uploads. Let's consider switching chunk uploads to zstd, from the current gzip.

Some considerations while implementing this change:

  • We need to add support for zstd uploads to both Sentry CLI and Sentry
  • We need to consider backwards compatibility. In the chunk upload options, we likely will not want to specify zstd in the compression field because older versions of Sentry CLI, which don't support zstd, will fallback to uncompressed uploads, rather than falling back to gzip.
    • One potential solution: deprecate the existing compression field, and continue setting it for gzip. Instead, introduce a new compression field which is set to a list of compression algorithms that the server supports. New versions of Sentry CLI , which support zstd and the new compression field, will always pick the first algorithm from the list which the CLI supports. Old versions of Sentry CLI, which neither understand the new field nor support zstd, will ignore the new field, and instead use gzip, as specified in the old field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant