Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate --use-artifact-bundle option #2347

Closed
szokeasaurusrex opened this issue Jan 20, 2025 · 0 comments · Fixed by #2349
Closed

Deprecate --use-artifact-bundle option #2347

szokeasaurusrex opened this issue Jan 20, 2025 · 0 comments · Fixed by #2349

Comments

@szokeasaurusrex
Copy link
Member

The --use-artifact-bundle option was never meant to be part of the public API. Passing it may have a harmful effect, since it causes artifact bundles to be uploaded, even when the Sentry server does not declare support for receiving them in the chunk upload options. However, we should keep the option around, as the JS bundler plugins use the option to ensure artifact bundles are sent. Removing the option completely (or making it a no-op) would potentially break compatibility with some versions of self-hosted Sentry, since support for receiving artifact bundles seems to have been added to Sentry before this support was declared in the chunk upload options.

szokeasaurusrex added a commit that referenced this issue Jan 20, 2025
Also, update the documentation to more clearly state what the option even does.

Ref #2347
szokeasaurusrex added a commit that referenced this issue Jan 21, 2025
Also, update the documentation to more clearly state what the option
even does.

Ref #2347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant