Transaction from sample results in successful transaction while capturing error

[bruno-garcia]

I ran the sample from the repo (see: #55 )

Since I dind't have the csv file, an error was captured:

https://sentry-sdks.sentry.io/issues/5957943782/?project=4508073336176640&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=14d&stream_index=0

Note the error isn't linked to a trace, but a transaction was happening at that time.

The trace during that error has a transaction with spans. The span ended with deadline_exceeded (That happens when the transaction was finished before the span was closed, although it's an odd behavior).

https://sentry-sdks.sentry.io/traces/?project=4508073336176640

https://sentry-sdks.sentry.io/performance/trace/27a276a9b8724129a80c3aa85b613d01/?eventId=d2cb0adb055e40f7b4c4106a5463aee5&project=4508073336176640&query=&referrer=performance-transaction-summary&source=performance_transaction_summary&statsPeriod=14d&timestamp=1728180601&transaction=transaction-name&unselectedSeries=p100%28%29&unselectedSeries=avg%28%29

But the transaction ended with success while it should have been a failure.
Today, the burden is on the caller to Finish the transaction with either an error status code, or the exception instance.

The latter will map to a relevant failing status:

https://github.com/getsentry/sentry-dotnet/blob/23ad0b4b3bbbdf106ef59cf7cc165c71cb417207/src/Sentry/TransactionTracer.cs#L402-L410