Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size classes #17

Open
jordibruin opened this issue Jul 3, 2022 · 2 comments
Open

Size classes #17

jordibruin opened this issue Jul 3, 2022 · 2 comments

Comments

@jordibruin
Copy link

Maybe we should return if the pip window is small, medium or large instead of just the value? Since it will depend on the ratio compared to the screen, and that will change based on how large the view etc is.

@Sherlouk
Copy link
Contributor

Sherlouk commented Jul 4, 2022

Sounds like an interesting idea!

I'm curious on the math that you're proposing here though because in my testing there doesn't always seem to be 3 different sizes that it can even scale to. In fact, I've had it on my phone where you can't change the size (so is that the smallest or largest? it's both 😂).

This is also technically something clients can implement themselves if they have custom business logic by extending the DockableController.

@jordibruin
Copy link
Author

Maybe we could pass the frame of the view through to the dockableController and based on that we can determine the relative size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants