Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/4.7.1 #474

Closed
wants to merge 5 commits into from
Closed

Release/4.7.1 #474

wants to merge 5 commits into from

Conversation

laurent-yoti
Copy link
Collaborator

@laurent-yoti laurent-yoti commented May 22, 2024 •
edited
Loading

Minor updates

Update of type for the error details surfaced in Identity Verification service

The 'requirements not met details' within the IdentityProfileRequirementsNotMetDetailResponse are now parsed as a class

const sessionResult = await idvClient.getSession(sessionId);
const identityProfile = sessionResult.getIdentityProfile();
if (identityProfile) {
  const failureReason = identityProfile.getFailureReason();

  if (failureReason) {
    const reasonCode = failureReason.getReasonCode(); // string
     // Array of IdentityProfileRequirementsNotMetDetailResponse (NEW - class based)
    const requirementsNotMetDetails = failureReason.getRequirementsNotMetDetails();
    /*
    IdentityProfileRequirementsNotMetDetailResponse shape as follows:
    {
      failureType, //string
      documentType, //string
      documentCountryIsoCode, //string
      auditId, //string
      details, //string
    }

    // Getters (NEW):
    .getFailureType() 
    .getDocumentType() {
    .getDocumentCountryIsoCode() {
    .getAuditId() {
    .getDetails() {
    */
  }
}

laurent-yoti and others added 3 commits May 22, 2024 09:35
@laurent-yoti
Removed extraneous query params "appId" in requests made by digital_i…
d507f4a 
…dentity_service
@laurent-yoti
SDK-2453 include requirements_not_met_details in scheme compliance (#472
4cccee3 
)

* Created class IdentityProfileRequirementsNotMetDetailResponse to parse/expose the RequirementsNotMetDetail object.
Updated IdentityProfileFailureReasonResponse to use IdentityProfileRequirementsNotMetDetailResponse
Modified IdentityProfileReportSchemesComplianceResponse to include conditionally requirementsNotMetDetails, as a list of IdentityProfileRequirementsNotMetDetailResponse

* Fixes for JSDoc/Typescript
@dependabot
Bump protobufjs from 7.2.6 to 7.3.0 (#470)
ff51050 
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.2.6 to 7.3.0.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md)
- [Commits](protobufjs/protobuf.js@protobufjs-v7.2.6...protobufjs-v7.3.0)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@laurent-yoti
Copy link
Collaborator Author

Not relevant for most part, and what was has been included in v4.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabh-yoti saurabh-yoti saurabh-yoti approved these changes

@abdalmajeed-yoti abdalmajeed-yoti abdalmajeed-yoti approved these changes

@jlmartyres jlmartyres jlmartyres approved these changes

@dhivya-pattabhiraman dhivya-pattabhiraman Awaiting requested review from dhivya-pattabhiraman

@mehmet-yoti mehmet-yoti Awaiting requested review from mehmet-yoti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurent-yoti @jlmartyres @abdalmajeed-yoti @saurabh-yoti