Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaintainResult::panic_on_timeout() doesn't seem to do anything #6407

Open
casey opened this issue Oct 13, 2024 · 1 comment
Open

MaintainResult::panic_on_timeout() doesn't seem to do anything #6407

casey opened this issue Oct 13, 2024 · 1 comment
Labels
type: bug Something isn't working

Comments

@casey
Copy link

casey commented Oct 13, 2024

I was curious what MaintainResult::panic_on_timeout was doing, so I checkout out the code.

However, it seems to be empty:

impl MaintainResult {
    /// Panics if the MaintainResult is not Ok.
    pub fn panic_on_timeout(self) {
        let _ = self;
    }
}

It looks like PR #5012 changes this. However, in the mean time, I would suggest adding a comment to this function explaining what's going on, since while digging in and trying to understand how things work, I found it pretty confusing.

@Wumpf
Copy link
Member

Wumpf commented Oct 15, 2024

might as well just remove it in the meantime given that it's always doing the wrong thing Oo

@Wumpf Wumpf added the type: bug Something isn't working label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants