Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check (all?) backends of profiling in CI #6462

Open
ErichDonGubler opened this issue Oct 24, 2024 · 0 comments
Open

Check (all?) backends of profiling in CI #6462

ErichDonGubler opened this issue Oct 24, 2024 · 0 comments
Labels
area: infrastructure Testing, building, coordinating issues area: tests Improvements or issues with our test suite

Comments

@ErichDonGubler
Copy link
Member

WGPU has had a multitude of compilation failures that make it into mainline history, caused by subtle differences in profiling backends. Some examples:

The root cause is, according to aclysma/profiling#87 (comment), significant tension between profiling wanting to be portable but also zero-cost when no backends are enabled, and no guarantee from Rust that unused expressions' side effects will be discarded. Resolving the root cause is interesting, but does not appear simple.

In the meantime, we can “simply” check profiling backends in CI, to ensure that we don't merge PRs that cause this again. If we can do this, we can mitigate the risk of the above problem, without actually needing to resolve it.

@ErichDonGubler ErichDonGubler added area: infrastructure Testing, building, coordinating issues area: tests Improvements or issues with our test suite labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Testing, building, coordinating issues area: tests Improvements or issues with our test suite
Projects
None yet
Development

No branches or pull requests

1 participant