From ac7a8547e5b57052af60ec12fd81c9abede2dda3 Mon Sep 17 00:00:00 2001 From: Luqman Hakim Date: Thu, 1 Dec 2016 23:28:26 +0800 Subject: [PATCH 1/4] prevent selected-object value changed when TAB is pressed when selected-object already contain valid value, then don't do handleOverrideSuggestions which will make the selected-object being override. i think the handleOverrideSuggestions logic is wrong when there is already a valid selected-object --- angucomplete-alt.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/angucomplete-alt.js b/angucomplete-alt.js index c188bd4c..62218f11 100644 --- a/angucomplete-alt.js +++ b/angucomplete-alt.js @@ -821,7 +821,8 @@ fieldTabindex: '@', inputName: '@', focusFirst: '@', - parseInput: '&' + parseInput: '&', + searchStr: '=ngModel' }, templateUrl: function(element, attrs) { return attrs.templateUrl || TEMPLATE_URL; From d528457875268cc93a8e2656b97246196e3b56d5 Mon Sep 17 00:00:00 2001 From: luqeckr Date: Thu, 1 Dec 2016 23:43:32 +0800 Subject: [PATCH 2/4] new fix not synced dunno why it doesn't sync correctly using github desktop --- angucomplete-alt.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/angucomplete-alt.js b/angucomplete-alt.js index 62218f11..6dee511c 100644 --- a/angucomplete-alt.js +++ b/angucomplete-alt.js @@ -29,6 +29,7 @@ var KEY_UP = 38; var KEY_LF = 37; var KEY_ES = 27; + var KEY_SHIFT = 16; var KEY_EN = 13; var KEY_TAB = 9; @@ -412,6 +413,9 @@ scope.$digest(); } } + else if (scope.selectedObject && scope.selectedObject.originalObject) { +// nothing todo, good to go + } else { // no results // intentionally not sending event so that it does not From 0dfd2538d916593420fb2217843948d92c551556 Mon Sep 17 00:00:00 2001 From: Luqman Hakim Date: Fri, 2 Dec 2016 11:21:59 +0800 Subject: [PATCH 3/4] prevent selected-object value changed when TAB is pressed when selected-object already contain valid value, then don't do handleOverrideSuggestions which will make the selected-object being override. i think the handleOverrideSuggestions logic is wrong when there is already a valid selected-object --- angucomplete-alt.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/angucomplete-alt.js b/angucomplete-alt.js index 62218f11..a4a03b87 100644 --- a/angucomplete-alt.js +++ b/angucomplete-alt.js @@ -412,6 +412,9 @@ scope.$digest(); } } + else if (scope.selectedObject && scope.selectedObject.originalObject) { +// nothing todo, good to go + } else { // no results // intentionally not sending event so that it does not From 03af0dc4fbbea192d1999ad076c9012c7799469c Mon Sep 17 00:00:00 2001 From: luqeckr Date: Fri, 2 Dec 2016 11:32:25 +0800 Subject: [PATCH 4/4] Update angucomplete-alt.js --- angucomplete-alt.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/angucomplete-alt.js b/angucomplete-alt.js index 6dee511c..a310c945 100644 --- a/angucomplete-alt.js +++ b/angucomplete-alt.js @@ -29,7 +29,6 @@ var KEY_UP = 38; var KEY_LF = 37; var KEY_ES = 27; - var KEY_SHIFT = 16; var KEY_EN = 13; var KEY_TAB = 9; @@ -825,8 +824,7 @@ fieldTabindex: '@', inputName: '@', focusFirst: '@', - parseInput: '&', - searchStr: '=ngModel' + parseInput: '&' }, templateUrl: function(element, attrs) { return attrs.templateUrl || TEMPLATE_URL;