From cd875dc008af5aa8611c9a7e0595bfd79453b293 Mon Sep 17 00:00:00 2001 From: Johannes Loher Date: Sat, 12 Nov 2022 10:27:22 +0100 Subject: [PATCH] fix: fix issue with old scene mask not being cleared on scene change --- src/particle-effects/scene-mask.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/particle-effects/scene-mask.js b/src/particle-effects/scene-mask.js index 4dc4e4b6..398a302d 100644 --- a/src/particle-effects/scene-mask.js +++ b/src/particle-effects/scene-mask.js @@ -4,6 +4,10 @@ export function registerSceneMaskFunctionality() { function drawSceneMask() { const msk = canvas.masks.depth; + if (msk.fxmasterSceneMask) { + msk.removeChild(msk.fxmasterSceneMask); + delete msk.fxmasterSceneMask; + } if (shouldMaskToScene()) { const mask = new PIXI.LegacyGraphics() .beginFill(0x0000ff) @@ -15,9 +19,6 @@ function drawSceneMask() { mask.mask = new PIXI.MaskData(); mask.mask.colorMask = PIXI.COLOR_MASK_BITS.BLUE; msk.fxmasterSceneMask = msk.addChild(mask); - } else if (msk.fxmasterSceneMask) { - msk.removeChild(msk.fxmasterSceneMask); - delete msk.fxmasterSceneMask; } }