Wrong config file opened

[PatrickF1]

Repro steps

1. install ghostty with no config file found in $XDG_CONFIG_HOME/ghostty/config
2. open the settings file through the UI (On Mac, I did Cmd+`). At this point, ghostty should create a template file
3. add a config file to $XDG_CONFIG_HOME/ghostty/config
4. quit and reopen ghostty / reload settings
5. open the settings file again through the UI. At this point, ghostty should open the previous template file even though it is clearly using the settings from $XDG_CONFIG_HOME/ghostty/config

My expectation is that opening up settings should open up $XDG_CONFIG_HOME/ghostty/config after step 4.

[lemorage]

Ghostty is loading the default config file by default after installation. To fix it, just to clear all contents at $HOME/Library/Application\ Support/com.mitchellh.ghostty/config, or you can just remove this file. After that, Ghostty will open your user-defined config at $XDG_CONFIG_HOME/ghostty/config next time.

[PatrickF1]

I see. Well since according to https://ghostty.org/docs/config#file-location $XDG_CONFIG_HOME/ghostty/config should take precedence if it exists over $HOME/Library/Application\ Support/com.mitchellh.ghostty/config, then I think if the former exists it should load that rather than the latter. Just my 2 cents.

[lemorage]

Yes! I saw that in the docs too, but the wording is a bit confusing. On macOS, Library/Application Support/com.mitchellh.ghostty/config is always checked after $XDG_CONFIG_HOME/ghostty/config, no matter what. The code does try XDG first, but it still loads the Application Support config afterwards. Also, the Application Support config will likely take precedence because it is loaded after the XDG config.

ghostty/src/config/Config.zig

Lines 3057 to 3088 in da32534

	/// Load configurations from the default configuration files. The default
	/// configuration file is at `$XDG_CONFIG_HOME/ghostty/config`.
	///
	/// On macOS, `$HOME/Library/Application Support/$CFBundleIdentifier/config`
	/// is also loaded.
	pub fn loadDefaultFiles(self: *Config, alloc: Allocator) !void {
	// Load XDG first
	const xdg_path = try internal_os.xdg.config(alloc, .{ .subdir = "ghostty/config" });
	defer alloc.free(xdg_path);
	const xdg_action = self.loadOptionalFile(alloc, xdg_path);
	// On macOS load the app support directory as well
	if (comptime builtin.os.tag == .macos) {
	const app_support_path = try internal_os.macos.appSupportDir(alloc, "config");
	defer alloc.free(app_support_path);
	const app_support_action = self.loadOptionalFile(alloc, app_support_path);
	// If both files are not found, then we create a template file.
	// For macOS, we only create the template file in the app support
	if (app_support_action == .not_found and xdg_action == .not_found) {
	writeConfigTemplate(app_support_path) catch |err| {
	log.warn("error creating template config file err={}", .{err});
	};
	}
	} else {
	if (xdg_action == .not_found) {
	writeConfigTemplate(xdg_path) catch |err| {
	log.warn("error creating template config file err={}", .{err});
	};
	}
	}
	}

[PatrickF1]

Oh I see, you mean that a config file that is loaded later takes precedence over a config file loaded earlier? Yeah that should semantic should be clarified then.
But then it does make sense for the settings to open up Library/Application Support/com.mitchellh.ghostty/config then.