-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid running Dex in a fork #630
Comments
The upstream issue this is related to is |
I just checked on the status upstream. It seems as if connector middlewares (which were the reason our PR was "rejected" or put on ice) don't have progressed at all. @puja108 You commented there almost a year ago. Would it make sense if you could try again? Or should someone else? The aspects we could mention are
|
I'd prefer if you or someone from Rainbow would continue the conversation, so you can steer it better in the right direction. I would then still be available to +1 and/or escalate (and can take that role better then). |
ACK, done |
Let's try again to contribute upstream now that all connectors work with prefixing. |
Did you manage to get this upstream? |
@jonaz unfortunately not. We were told that it might be part of dexidp/dex#1635 but the issue is still open. |
i did remind them here: dexidp/dex#918 (comment) |
no news upstream for 2 years, not sure if we are going to use dex in the future anyways, closing for now. will revisit when discussing future of Dex |
Description
We are running a fork of Dex atm because we rely on support for the prefixing of group names with automatic id. These changes were declined upstream because they plan to implement middleware and design is far from being something that contributors agreed on.
Changes proposed upstream - dexidp/dex#2051
Alternative - https://github.com/giantswarm/giantswarm/issues/16933 Find a solution to avoid 'customer:' group name prefix
TODO
The text was updated successfully, but these errors were encountered: