Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite-amalgamation - can we delete it? #38

Open
CodeSmile-0000011110110111 opened this issue Jan 12, 2025 · 2 comments
Open

sqlite-amalgamation - can we delete it? #38

CodeSmile-0000011110110111 opened this issue Jan 12, 2025 · 2 comments

Comments

@CodeSmile-0000011110110111

I noticed that sqlite-amalgamation folder is 9 megs but contains only the C source code for SQLite. Is this needed for IL2CPP builds or can we safely delete the folder?

Couldn't find any mention anywhere so consider it a "documentation issue". ;)

@gilzoide
Copy link
Owner

gilzoide commented Jan 12, 2025

Hey @CodeSmile-0000011110110111, thanks for the question.

Yes, currently SQLite is compiled from source on iOS, tvOS and visionOS builds. It could be compiled as a static library instead, but we need this code to build for the other platforms as well, so it must be on the repository anyway. Even the header "sqlite3.h" is used by idbvfs.cpp on WebGL builds and cannot be removed, the only one that's not used at all is "sqlite3ext.h", the smallest of them.

If your project does not support iOS/tvOS/visionOS/WebGL, feel free to delete them in your local copy of the package. I won't remove them from this repository, unless the build is changed to use Git submodules and we build static libraries for these platforms. This would be low priority, 9 megs in project size is not a huge problem in general. If it were 9 megs in build size for web/mobile, then I'd be more worried.

consider it a "documentation issue". ;)

In the README there's a brief mention of SQLite being built from source in the mentioned platforms: https://github.com/gilzoide/unity-sqlite-net/blob/main/README.md?plain=1#L15
Maybe this is not clear enough, of course, but anyway.

@gilzoide
Copy link
Owner

By the way, if you think your question isn't exactly an Issue, you could use the Discussions page instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants