From f4af693b863695239f77d1e02e0723cf16324bcc Mon Sep 17 00:00:00 2001 From: David Manthey Date: Mon, 4 Oct 2021 15:00:09 -0400 Subject: [PATCH] Add a more precise class to the image viewer selector. --- CHANGELOG.md | 5 +++++ .../web_client/templates/imageViewerSelectWidget.pug | 2 +- .../web_client/views/imageViewerSelectWidget.js | 6 +++--- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4291576d5..2191a69f2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Change Log +## Version 1.8.2 + +### Improvements +- Make the image viewer control class more precise (#665) + ## Version 1.8.1 ### Improvements diff --git a/girder/girder_large_image/web_client/templates/imageViewerSelectWidget.pug b/girder/girder_large_image/web_client/templates/imageViewerSelectWidget.pug index 757b128dd..22f71fe7d 100644 --- a/girder/girder_large_image/web_client/templates/imageViewerSelectWidget.pug +++ b/girder/girder_large_image/web_client/templates/imageViewerSelectWidget.pug @@ -2,7 +2,7 @@ .g-item-info-header i.icon-picture span Image Viewer - select.form-control.input-sm + select.form-control.input-sm.image-viewer-control each viewer in viewers option(value=viewer.name) #{viewer.label} .image-controls diff --git a/girder/girder_large_image/web_client/views/imageViewerSelectWidget.js b/girder/girder_large_image/web_client/views/imageViewerSelectWidget.js index 63a707284..c4362db52 100644 --- a/girder/girder_large_image/web_client/views/imageViewerSelectWidget.js +++ b/girder/girder_large_image/web_client/views/imageViewerSelectWidget.js @@ -31,10 +31,10 @@ wrap(ItemView, 'render', function (render) { var ImageViewerSelectWidget = View.extend({ events: { - 'change select': function (event) { + 'change select.image-viewer-control': function (event) { this._selectViewer(event.target.value); }, - 'keyup select': function (event) { + 'keyup select.image-viewer-control': function (event) { this._selectViewer(event.target.value); }, 'input #image-frame,#image-frame-number': function (event) { @@ -60,7 +60,7 @@ var ImageViewerSelectWidget = View.extend({ if (_.findWhere(largeImageConfig.viewers, {name: name}) === undefined) { name = largeImageConfig.viewers[0].name; } - this.$('select.form-control').val(name); + this.$('select.form-control.image-viewer-control').val(name); this._selectViewer(name); return this; },