-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Available Levels Fails with Large SVS Images: Not a JPEG file: starts with 0xff 0x11 #1759
Comments
Do you have a sample file you can share that throws an error? We test and use this with files over 4 GB. What OS are you using and what version of openslide (are you using the wheels supplied by openslide or by large_image_wheels or by a library installed on your system)? There are svs files that don't populate all levels (for instance, some of the TCGA images only have 20x, 5x, and 1.25x magnifications), and testing for this allows us to read these files more efficiently, so disabling this check would degrade or break read performance on those files. |
I wasn't sure about the specific version given I built on another computer I'm no longer using. I downloaded the 4.0.0.6 binary from the openslide website (https://openslide.org/download/#binaries) and attempted running the code with this binary. It seems to be working now with the updated dll. I'm going to close this issue since I was able to get it working, but if I am able to reproduce it I will reopen. If you look at this you can see that the code handles for the case when in large aperio files it can't be read specifically at 0,0 because it is partially overwritten which overrides the JPEG marker. |
Thanks. We run our CI tests against the latest version from openslide, so in this case it returns a tile (just the missing-tile tile, but it is still a tile that validates reading the level). It probably means we should check the version of openslide and if it is too old issue some sort of warning. |
@manthey @dgutman I'm noticing the same problem when using large_image in the Deid application that we've been working with. In this particular environment we are compiling an exec for a python engine that runs as a backend for the application that should open the file with the openslide tile source. Is it possible for you to test a file above 4GB after compiling something with pyinstaller? Can a test case be added that checks if it works with this kind of file after being made into an executable with pyinstaller? |
The tile source might be using your system openslide in preference to the bundled openslide depending on how it resolves paths within how pyinstaller lays things out. We don't actually bundle large_image with pyinstaller in any test, so this would be some work -- but we'd be happy to add such a test if you have a bare-bones starting point for it. |
When attempting to open an SVS in large using the openslide tile source fails when attempting to get available levels with an error:
'Not a JPEG file: starts with 0xff 0x11'
If I comment out the read_region call then the tile source works without issue. Does read region here serve a specific functionality given how it uses openslide which have already created a patch for this error? I would like to suggest just commenting this line or rewriting this code so that it works with files above 4 GB. This is a breaking issue for my current project and it requires me manually changing this line of code whenever I update large image.
The text was updated successfully, but these errors were encountered: