Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discarding changes doesn't function #5222

Open
ipsquiggle opened this issue Oct 18, 2024 · 3 comments
Open

Discarding changes doesn't function #5222

ipsquiggle opened this issue Oct 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ipsquiggle
Copy link

It currently seems impossible to discard a change through the GitButler UI.

I've tried both

  • right-clicking on a Changed File > Discard Changes > Confirm (dialog remains open, nothing happens)
  • right-clicking on a hunk > Discard (nothing happens)

Tested in v0.13.2, Windows 10

Let me know if there's any other information I can provide.

@Byron Byron added bug Something isn't working feedback requested Feedback was requested to help resolve the issue labels Oct 19, 2024
@Byron
Copy link
Collaborator

Byron commented Oct 19, 2024

Thanks for reporting!

Last time I checked I noticed that it was only able to discard worktree changes, but not anything else, i.e. changes that are added to the index, or files removed from the index.

Is this what you are describing here, or there more to it that should be shared?
Thanks again.

@ipsquiggle
Copy link
Author

@Byron I don't think I'm doing anything fancy.. my workflow is 100% GitButler.. I make some change (i.e. adding a logging line) that I later want to remove. I right click on the change and "Discard" and nothing happens.

I've tried this after rebooting, on different branches, etc. The behaviour is perfectly consistent for me, my experience is that this feature simply doesn't work.

I have just attempted to discard using both the methods described in the OP, and then chose the "Share Debug Info" with a reference to this issue. I hope that helps!

@Byron
Copy link
Collaborator

Byron commented Oct 22, 2024

Thanks a lot for the heads-up and for sending the report. This means the logs where sent to the team.
You can also take a look at them yourself, I'd expect an error to show up right after trying to discard an entry. Maybe you could also share that here.

@Byron Byron removed the feedback requested Feedback was requested to help resolve the issue label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants