Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide config via context in Explorer #2707

Open
bard opened this issue Nov 29, 2023 · 0 comments
Open

Provide config via context in Explorer #2707

bard opened this issue Nov 29, 2023 · 0 comments
Labels
chore engineering

Comments

@bard
Copy link
Contributor

bard commented Nov 29, 2023

Overview

Reduce unnecessary complexity, avoid requiring mocks.

Details

  1. Read configuration in grant-explorer/src/index.tsx using already imported getConfig() and make it available in components via a new ConfigProvider context.
  2. Remove imports of getConfig from ProjectCard.tsx, ProjectBanner.tsx, etc.
  3. Update tests to addConfigProvider and remove mocks of common/src/config.
@bard bard added this to Grants Lab Nov 29, 2023
@bard bard moved this to Backlog in Grants Lab Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore engineering
Projects
Grants Lab
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bard