Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

there is no code coverage #1

Open
iancrowther opened this issue Jan 6, 2016 · 6 comments
Open

there is no code coverage #1

iancrowther opened this issue Jan 6, 2016 · 6 comments

Comments

@iancrowther
Copy link
Contributor

we need to complete the tests to achieve 100% code coverage

@mike182uk
Copy link
Contributor

There have been some tests contributed. We can generate code coverage using istanbul but where should this coverage be visible? I would not recommend the coverage being in the repo itself. I would suggest using something like codeclimate (which already looks to be used by gitevents/core. This would also probably require a build step (using travis ci or something similar) to have the code coverage sent to codeclimate on new changes.

@iancrowther
Copy link
Contributor Author

"I would not recommend the coverage being in the repo itself" - how come? surely it just an output in the test report

@iancrowther
Copy link
Contributor Author

whats wrong with https://www.npmjs.com/package/istanbul?

@iancrowther
Copy link
Contributor Author

codeclimate for me is candy (which im fine to add) however we should be able to get these metrics without the dependancy of saas tools

@PatrickHeneise
Copy link
Member

👍 istanbul should be configured with the project; codeclimate is nice to have (free for open source)

@mike182uk
Copy link
Contributor

@iancrowther In the issue i suggested Istanbul...

I meant i would not store the output from the tool in the repo itself. Why? Because i don't really see a need for this output to be in the repo itself. It just bloats the repo and easily become out of date if its not generated for every single change. Why not just send the coverage to codeclimate and let that keep track of it for us?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants