Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for non-x86-64 archs #2

Open
myyk opened this issue Nov 24, 2022 · 1 comment
Open

Better support for non-x86-64 archs #2

myyk opened this issue Nov 24, 2022 · 1 comment

Comments

@myyk
Copy link

myyk commented Nov 24, 2022

Firstly, thanks for this awesome template! I'm pretty new to Next, so I'm sorry if this isn't a very good issue.

I believe that the mcr.microsoft.com/devcontainers/universal:2 image used in this template is only built for x86-64 arch according to https://github.com/microsoft/vscode-dev-containers/tree/main/containers/codespaces-linux. I'm guessing this is going to run into many performance issues for amd64 users like me on Apple silicon.

I found a simple change like this seems to at least work enough for a template: main...myyk:codespaces-nextjs:patch-1 (pls excused the misleading comment on it and the bad formatting)

I don't know if there are other reasons why devcontainers/universal was used instead of devcontainers/typescript-node though.

@RanaRabees
Copy link

You Looks Right myyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants