Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: replace custom glob with minimatch for improved pattern matching #750

Open
wants to merge 1 commit into
base: main-enterprise
Choose a base branch
from

Conversation

PendaGTP
Copy link
Contributor

@PendaGTP PendaGTP commented Jan 24, 2025

Description

Fixes #748

Replace custom glob implementation with minimatch.

Changes

  • Replace custom glob implementation with minimatch to fully support glob patterns
  • Remove support for Regex patterns
  • Simplify logic for matching glob patterns
  • Update and improve related documentation

⚠️ BREAKING CHANGES: ⚠️

Removed Regex support for patterns. Users must update their configuration to use glob syntax.

Before:

exclude: ['^admin$', '^\.github$', '^safe-settings$', '.*-test']

After:

restrictedRepos: ['admin', '.github', 'safe-settings', '*-test']

This change simplifies the configuration and doesn't significantly impact existing functionality.

Testing

  • Ensured all unit tests pass
  • Removed glob.test.ts as it's no longer necessary
  • Performed minimal manual testing

@PendaGTP PendaGTP force-pushed the fix/glob-pattern-matching branch 2 times, most recently from 9232961 to b3aba96 Compare January 24, 2025 18:37
@PendaGTP PendaGTP changed the title fix: replace custom glob with minimatch for improved pattern matching fix!: replace custom glob with minimatch for improved pattern matching Jan 24, 2025
@PendaGTP PendaGTP force-pushed the fix/glob-pattern-matching branch from b3aba96 to a247e01 Compare January 24, 2025 18:46
@PendaGTP
Copy link
Contributor Author

Note:

This PR doesn't impact:

  • labels regex
  • validator regex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suborgproperties is matching too many repositories
1 participant