Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI test failure #3745

Closed
github-actions bot opened this issue Oct 4, 2024 · 5 comments
Closed

CLI test failure #3745

github-actions bot opened this issue Oct 4, 2024 · 5 comments

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

CLI tests have failed on the default branch.

@github/code-scanning-secexp-reviewers

Copy link
Contributor Author

github-actions bot commented Oct 4, 2024

CLI test 11171711497 failed on ref refs/heads/main

1 similar comment
Copy link
Contributor Author

github-actions bot commented Oct 4, 2024

CLI test 11171711497 failed on ref refs/heads/main

@koesie10
Copy link
Member

koesie10 commented Oct 4, 2024

This seems like a genuine failure. These are the changes between the two runs: https://github.com/github/vscode-codeql/compare/a1033eb498491fe7efcd2e18a416f337c4be9153..d16fbfd60e1892942b2130dc2bc8b9fc8fd6d567

The runner version has also been updated from 2.319.1 to 2.320.0 between the two runs, which could also be related. However, neither the Runner image or the Node version have updated, so this is quite unlikely.

@koesie10
Copy link
Member

koesie10 commented Oct 4, 2024

A new version of VS Code was released 14 hours ago which seems like the most likely cause: I can reproduce this failure locally, even on commits for which the nightly run previously passed. I'll look into the changes in that release which cause our patch to stop working.

@koesie10
Copy link
Member

koesie10 commented Oct 4, 2024

A run on latest main (with #3746 included) has succeeded: https://github.com/github/vscode-codeql/actions/runs/11176795394

@koesie10 koesie10 closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant