Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate different Button-type components to use Button variants #1364

Open
setchy opened this issue Jul 11, 2024 · 0 comments
Open

Consolidate different Button-type components to use Button variants #1364

setchy opened this issue Jul 11, 2024 · 0 comments
Labels
priority:low Items of low importance. Applicable to select few users or use-cases refactor Refactoring of existing feature

Comments

@setchy
Copy link
Member

setchy commented Jul 11, 2024

📝 Provide a description of the new feature

Currently we have a variety of Button-type components

  • Button
  • InteractiveButton
  • PillButton
  • SidebarButton

Recently, we introduced class-variance-authority to the Button component and a handful of variants

➕ Additional Information

Consider consolidating all of the above components into a single Button component, with some clear variants for each use-case sidebar, interactive, pill, etc
@setchy setchy added enhancement New feature or enhancement to existing functionality refactor Refactoring of existing feature and removed enhancement New feature or enhancement to existing functionality labels Jul 11, 2024
@setchy setchy changed the title Consolidate different Button components to use Button variants Consolidate different Button-type components to use Button variants Jul 11, 2024
@setchy setchy added the priority:low Items of low importance. Applicable to select few users or use-cases label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:low Items of low importance. Applicable to select few users or use-cases refactor Refactoring of existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@setchy