Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth Login Flows should use system browser, not electron window #485

Open
jgentil opened this issue Feb 11, 2021 · 4 comments · May be fixed by #654
Open

OAuth Login Flows should use system browser, not electron window #485

jgentil opened this issue Feb 11, 2021 · 4 comments · May be fixed by #654
Assignees
@bmulholland
Labels
blocked Is blocked by another issue or dependency enhancement New feature or enhancement to existing functionality priority:high Items of high importance. Applicable to all users or use-cases

Comments

@jgentil
Copy link

jgentil commented Feb 11, 2021

When I click to login to GitHub, it takes me to an Electron browser window. I would much rather do an OAuth2 exchange than type my username and password into an app like this, since I have credentials saved in a password manager AND I use a security key to OTP.

Gitify should open the authentication in a browser, not in itself.

I'll use a security token for now.
@WardsParadox
Copy link

Can we have an option to open in browser to meet a middle ground between these two styles?

@bmulholland bmulholland linked a pull request Oct 4, 2023 that will close this issue
Draft
11 tasks
@bmulholland
Copy link
Collaborator

I've started on this work in #654. Help is very welcomed.

@bmulholland bmulholland reopened this Oct 4, 2023
@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jan 19, 2024
@setchy setchy added priority:high Items of high importance. Applicable to all users or use-cases blocked Is blocked by another issue or dependency labels Jun 17, 2024
@setchy setchy mentioned this issue Aug 14, 2024
Closed
@setchy setchy changed the title Login Popup should use system browser, not Electron window. OAuth Login Flows should use system browser, not electron window Aug 14, 2024
@florianmutter
Copy link

Is there any progress on this? This would be very nice, so we would not have to fiddle with PATs anymore.

@bmulholland
Copy link
Collaborator

bmulholland commented Nov 8, 2024 •
edited
Loading

Sadly not. It's a big lift and I haven't had time. Would you be willing to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmulholland bmulholland

Labels
blocked Is blocked by another issue or dependency enhancement New feature or enhancement to existing functionality priority:high Items of high importance. Applicable to all users or use-cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(auth): Support 2FA via browser window auth gitify-app/gitify
5 participants
@jgentil @bmulholland @setchy @WardsParadox @florianmutter