Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third Party Cookie Consent #160

Open
Shofiul-Alam opened this issue Jul 12, 2024 · 3 comments
Open

Third Party Cookie Consent #160

Shofiul-Alam opened this issue Jul 12, 2024 · 3 comments

Comments

@Shofiul-Alam
Copy link

Need to implement third party cookie consent. Implementing
https://support.google.com/chrome/a/answer/14439269?hl=en

image

@givanz
Copy link
Owner

givanz commented Jul 12, 2024

I'm unable to find a page that sets 3rd party cookies to see these warnings in the console.

Can you please provide more details?

@Shofiul-Alam
Copy link
Author

Shofiul-Alam commented Jul 15, 2024

Hi,
It happes once I load the builder page, edit something and scroll the page.

image

I found that cookie-notice plugin sloved this problem. But also I found bug in cookie-notice plugin's javascript. The following fixes needed to be implemented in notice.html from line 36.

let notice = document.querySelectorAll("#cookie-notice .toast");
if (localStorage) {

let cookie = localStorage.getItem("cookie-notice", "unset");

if (!cookie && notice && notice.length) {
	notice.forEach((i) => i.classList.add("show"));
}

}

@givanz
Copy link
Owner

givanz commented Jul 16, 2024

Hi

Thanks for feedback.

It seems that the embed google maps from contact form section sets cookies that triggers these chrome warnings.

I managed to reproduce them once but now I no longer seem them in the console, maybe different google maps code loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants