Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad praise score values in frontend #1104

Open
Vyvy-vi opened this issue Jul 1, 2023 · 0 comments
Open

Pad praise score values in frontend #1104

Vyvy-vi opened this issue Jul 1, 2023 · 0 comments

Comments

@Vyvy-vi
Copy link
Collaborator

Vyvy-vi commented Jul 1, 2023

Details

The total_praise_score values have long decimal values that terminate after a while but these are insignificant digits (perhaps it's time to look if there are some floating point inaccuracies in the codebase?)

Main success scenario

This shouldn't be displayed in the frontend. We should round or pad these these values to 2 or 3 decimal places to prevent weird UI breaks.

Links and docs

Screenshot 2023-07-01 at 8 46 07 AM

Who should be kept in the loop?

@kristoferlund @kkatusic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant