Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline and update routines in hourly utils #80

Open
rjhd2 opened this issue Aug 25, 2023 · 1 comment
Open

Streamline and update routines in hourly utils #80

rjhd2 opened this issue Aug 25, 2023 · 1 comment

Comments

@rjhd2
Copy link
Contributor

rjhd2 commented Aug 25, 2023

During development for #79, found that the remove_missing_data_rows() wasn't doing anything. "Null", "null" "nan" and NaN are all used throughout these scripts without much consistency - and so some search/replace actions don't work. Also some fillna() actions work on the entire dataframe which has knockon impacts downstream.

Finally, many actions could have an inplace=True option set, which might speed up and reduce memory requirements.

With some known good outputs, go through to tidy and tweak.

@sjnoone
Copy link
Contributor

sjnoone commented Aug 28, 2023

Sorry I can't remember why I wrote that way. we can reveiw after r.06 is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants