Issues with preflight again

[Tampa]

There were some changes to gridinfo data and some other things which might be the cause of this, but once again the parcel purchase preflight is failing.

Log from Firestorm:

2021-02-05T18:27:07Z INFO # llui/llfloaterreg.cpp(284) LLFloaterReg::showInstance : show instance for refreshing group ID: 
2021-02-05T18:27:07Z INFO # llui/llfloater.cpp(692) LLFloater::openFloater : Opening floater buy land full path: /main_view/menu_stack/world_panel/Floater View/buy land
2021-02-05T18:27:07Z WARNING # llui/llview.h(721) LLView::getChild : Making dummy class LLView named "remove_group_donation" in buy land
2021-02-05T18:27:08Z WARNING # newview/llxmlrpctransaction.cpp(275) LLXMLRPCTransaction::Handler::onCompleted : LLXMLRPCTransaction response has no body. status=00c80000: 
2021-02-05T18:27:08Z WARNING # newview/llxmlrpctransaction.cpp(278) LLXMLRPCTransaction::Handler::onCompleted : LLXMLRPCTransaction request URI: http://xx.xx.xxx.xxx:12170/landtool.php

Using latest master from OpenSim and Gloebit with new flows for http etc.

Setup a test parcel for sale on hg.zetaworlds.com/Warehouse for 1G$ if you want to test.

[Tampa]

Added a pull request that seems to resolve the issue for the most part. Not sure what the initial idea behind the define was, but it seems somehow it is causing parts of code not to run even if it should. Going forward might be best to drop support for older OpenSim versions, even if that is a hard decision the fixes introduced into current master are in some concerns quite severe, especially in terms of the bugs that were fixed since the last release.

[Tampa]

I noticed today there is unused code in the preflight for the levels and membership levels that is entirely unused in the return. Making me think the only thing viewers actually look for is the success parameter and everything else might not be required at all.